hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Wang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5163) miscellaneous cache pool RPC fixes
Date Fri, 06 Sep 2013 06:24:53 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13759979#comment-13759979
] 

Andrew Wang commented on HDFS-5163:
-----------------------------------

Thanks Colin, deferring the PB changes to another JIRA is fine. Mostly nitty comments this
go around, and a few small things I missed last time:

* earlier comment about modifyCachePool still applies, it should be annotated AtMostOnce in
ClientProtocol.
* In CachePool, we can assign the mode via the FsPermission copy constructor, rather than
converting into a short and back. {{#setMode}} should probably also use the copy constructor,
since FsPermission is mutable (which is kinda uncool).
* in CachePoolInfo#toString, we can just use FsPermission's toString rather than calling String.format
to zero-pad the short.
* shouldn't we clear the pool maps as well in {{CacheManager#clear}}?
* removing a pool should also remove entries associated with that pool, you could reuse the
currently committed code.

+1 once these are addresed, TYs.
                
> miscellaneous cache pool RPC fixes
> ----------------------------------
>
>                 Key: HDFS-5163
>                 URL: https://issues.apache.org/jira/browse/HDFS-5163
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-5163-caching.001.patch, HDFS-5163-caching.002.patch
>
>
> some minor fixes-- see below.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message