hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4988) Datanode must support all the volumes as individual storages
Date Wed, 25 Sep 2013 15:42:04 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13777631#comment-13777631
] 

Tsz Wo (Nicholas), SZE commented on HDFS-4988:
----------------------------------------------

Arpit, thanks for putting effort on splitting the patch.  The current patch is still big and
some of the code are just renaming method/variable names, e.g. storageID => storageUuid,
volumeMap => globalReplicaMap.  First of all, I suggest moving the rename to a separated
JIRA like you did before.  It is really confusing when mixing rename with the real logical
changes.

Secondly, do we really need to do the rename?  What's wrong to call it "storageID"?  An ID
could be a UUID.  In the second case, the new name globalReplicaMap may be misleading - it
sounds like a global cluster replica map.  Also, the volumeMap was there for a very long time.
 I think we should not rename it unless there is a significant change of it.
                
> Datanode must support all the volumes as individual storages
> ------------------------------------------------------------
>
>                 Key: HDFS-4988
>                 URL: https://issues.apache.org/jira/browse/HDFS-4988
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode
>            Reporter: Suresh Srinivas
>            Assignee: Arpit Agarwal
>         Attachments: HDFS-4988.01.patch, HDFS-4988.02.patch, HDFS-4988.03.patch, HDFS-4988.04.patch,
HDFS-4988.05.patch
>
>
> Currently all the volumes on datanode is reported as a single storage. This change proposes
reporting them as individual storage. This requires:
> # A unique storage ID for each storage
> #* This needs to be generated during formatting
> # There should be an option to allow existing disks to be reported as single storage
unit for backward compatibility.
> # A functionality is also needed to split the existing all volumes as single storage
unit to to individual storage units.
> # -Configuration must allow for each storage unit a storage type attribute. (Now HDFS-5000)-
> # Block reports must be sent on a per storage basis. In some cases (such memory tier)
block reports may need to be sent more frequently. That means block reporting period must
be on a per storage type basis.
> My proposal is for new clusters to configure volumes by default as separate storage unit.
Lets discuss.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message