Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 8 Aug 2013 22:34:49 +0000 (UTC)
From: "Suresh Srinivas (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12661011.1375311753291.28670.1376001289112@arcas>
In-Reply-To: <JIRA.12661011.1375311753291@arcas>
References: <JIRA.12661011.1375311753291@arcas>
Subject: [jira] [Commented] (HDFS-5052) Add cacheRequest/uncacheRequest
 support to DFSAdmin and NameNode
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-5052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13734102#comment-13734102 ] 

Suresh Srinivas commented on HDFS-5052:
---------------------------------------

I think we should update the design document based on comments from the discussion, captured in HDFS-4949. 

Few early comments:
# All newly added public methods in DistributedFileSystem and other places need javadoc. It is okay to point to the corresponding method in ClientProtocol.
# cacheRequest should include expiration. How is the pool associated with this request passed? So needs to include pool and we should get the pool abstraction into the code before these changes.
# uncacheRequest needs to include pool information.
# "Ask the NameNode to start caching some files or directories" This could be documented better. We should add a brief description of how the cache works.
# Do we need a notion of a unique cache ID returned for every cached attempt, to be used for subsequent operations? How does one correlated two caches created for the same path. How does uncache work, if the path is the only identifier?
# CacheManager.java
#* Needs javadoc
#* Again here is where we may need to add an identifier for cache ID.
#* Can you add comments on why you need a TreeMap?

                
> Add cacheRequest/uncacheRequest support to DFSAdmin and NameNode
> ----------------------------------------------------------------
>
>                 Key: HDFS-5052
>                 URL: https://issues.apache.org/jira/browse/HDFS-5052
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-5052.003.patch, HDFS-5052.004.patch
>
>
> Add cacheRequest/uncacheRequest/listCacheRequest support to DFSAdmin and NameNode.  Maintain a list of active CachingRequests on the NameNode.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira