hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5136) MNT EXPORT should give the full group list which can mount the exports
Date Fri, 30 Aug 2013 06:50:54 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754437#comment-13754437
] 

Jing Zhao commented on HDFS-5136:
---------------------------------

The patch looks good. Some minors:

1. Looks like MountResponse is just a helper class, and now we want to add a new "writeExportList"
method that can output the host group name based on the exports matcher. Thus instead of converting
static methods to non-static and add a subclass for MountResponse, maybe we can just add a
new helper method in MountResponse which takes an NfsExports object as extra parameter? We
should also move the security package to hadoop-nfs project.

2. Need to fix the javadoc warnings:
{noformat}
[WARNING] Javadoc Warnings
[WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/Nfs3MountResponse.java:43:
warning - Tag @link: reference not found: MountInterface.MNTPROC#EXPORT
[WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/Nfs3MountResponse.java:43:
warning - Tag @link: reference not found: MountInterface.MNTPROC#EXPORT
[WARNING] /home/jenkins/jenkins-slave/workspace/PreCommit-HDFS-Build/trunk/hadoop-hdfs-project/hadoop-hdfs-nfs/src/main/java/org/apache/hadoop/hdfs/nfs/mount/Nfs3MountResponse.java:43:
warning - Tag @link: reference not found: MountInterface.MNTPROC#EXPORT
{noformat}
                
> MNT EXPORT should give the full group list which can mount the exports
> ----------------------------------------------------------------------
>
>                 Key: HDFS-5136
>                 URL: https://issues.apache.org/jira/browse/HDFS-5136
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Brandon Li
>            Assignee: Brandon Li
>         Attachments: HDFS-5136.patch, HDFS-5136.patch.2
>
>
> Currently MNT.EXPORT command returns empty group list which is considered as "everybody
can mount the export". It should return the correctly configured group list.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message