hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5077) NPE in FSNamesystem.commitBlockSynchronization()
Date Tue, 27 Aug 2013 23:29:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13751883#comment-13751883
] 

Konstantin Shvachko commented on HDFS-5077:
-------------------------------------------

Looks good. Minor thing.
The test case fails without the patch on the first call to {{commitBlockSynchronization()}}
throwing the NPE.
So you don't need to mock the result of {{getStoredBlock()}} in your test. Seems a redundant
action.
Everything passes with the patch applied.
                
> NPE in FSNamesystem.commitBlockSynchronization()
> ------------------------------------------------
>
>                 Key: HDFS-5077
>                 URL: https://issues.apache.org/jira/browse/HDFS-5077
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.5-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Plamen Jeliazkov
>         Attachments: HDFS-5077_2.patch, HDFS-5077.patch
>
>
> NN starts a block recovery, which will synchronize block replicas on different DNs. In
the end one of DNs will report the list of the nodes containing the consistent replicas to
the NN via commitBlockSynchronization() call. The NPE happens if just before processing commitBlockSynchronization()
NN removes from active one of DNs that are then reported in the call.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message