hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4754) Add an API in the namenode to mark a datanode as stale
Date Tue, 06 Aug 2013 20:46:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13731243#comment-13731243
] 

Hadoop QA commented on HDFS-4754:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12596387/4754.v4.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4773//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4773//console

This message is automatically generated.
                
> Add an API in the namenode to mark a datanode as stale
> ------------------------------------------------------
>
>                 Key: HDFS-4754
>                 URL: https://issues.apache.org/jira/browse/HDFS-4754
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client, namenode
>            Reporter: Nicolas Liochon
>            Assignee: Nicolas Liochon
>            Priority: Critical
>         Attachments: 4754.v1.patch, 4754.v2.patch, 4754.v4.patch
>
>
> There is a detection of the stale datanodes in HDFS since HDFS-3703, with a timeout,
defaulted to 30s.
> There are two reasons to add an API to mark a node as stale even if the timeout is not
yet reached:
>  1) ZooKeeper can detect that a client is dead at any moment. So, for HBase, we sometimes
start the recovery before a node is marked staled. (even with reasonable settings as: stale:
20s; HBase ZK timeout: 30s
>  2) Some third parties could detect that a node is dead before the timeout, hence saving
us the cost of retrying. An example or such hw is Arista, presented here by [~tsuna] http://tsunanet.net/~tsuna/fsf-hbase-meetup-april13.pdf,
and confirmed in HBASE-6290.
> As usual, even if the node is dead it can comeback before the 10 minutes limit. So I
would propose to set a timebound. The API would be
> namenode.markStale(String ipAddress, int port, long durationInMs);
> After durationInMs, the namenode would again rely only on its heartbeat to decide.
> Thoughts?
> If there is no objections, and if nobody in the hdfs dev team has the time to spend some
time on it, I will give it a try for branch 2 & 3.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message