hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vivek Ganesan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2933) Datanode index page on debug port not useful
Date Mon, 19 Aug 2013 13:19:49 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Vivek Ganesan updated HDFS-2933:
--------------------------------

    Attachment: HDFS-2933.patch.2

LOCAL PATCH VALIDATION RESULTS

==========================================
{color:red}-1 overall{color}.  

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 42 warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

==========================================

No new tests were added because changes were in web pages only.  No core functionalities have
been changed.

To test the changes, 

1. Visit datanode's web port (50075) using web browser.  Typically, in a single node installation,
this address would be http://localhost:50075
2. Instead of links to WEB-INF, one can see the version related information of the datanode
and some relevant links regarding the datanode.
3. Verify each link redirects to the expected location.

Javadoc violations seem to be false positives, which is known to occur in my machine for some
patches in the past.  Jenkins does not give these javadoc warnings.
                
> Datanode index page on debug port not useful
> --------------------------------------------
>
>                 Key: HDFS-2933
>                 URL: https://issues.apache.org/jira/browse/HDFS-2933
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: datanode
>    Affects Versions: 1.0.0, 2.0.0-alpha
>            Reporter: Philip Zeyliger
>            Assignee: Vivek Ganesan
>              Labels: newbie
>         Attachments: HDFS-2933.patch, HDFS-2933.patch.1, HDFS-2933.patch.2, prototype_datanode_home_new.png
>
>
> If you visit the root page of a datanode's web port, you get an index page with WEB-INF
and robots.txt.  More useful would be to include information about the datanode, like its
version, and links to /browseDirectory, /jmx, /metrics, /conf, etc.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message