Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6B6F310C4E for ; Thu, 18 Jul 2013 13:19:04 +0000 (UTC) Received: (qmail 24395 invoked by uid 500); 18 Jul 2013 13:18:55 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 24310 invoked by uid 500); 18 Jul 2013 13:18:54 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 24084 invoked by uid 99); 18 Jul 2013 13:18:52 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 18 Jul 2013 13:18:52 +0000 Date: Thu, 18 Jul 2013 13:18:52 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-5003) TestNNThroughputBenchmark failed caused by existing directories MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-5003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712304#comment-13712304 ] Hudson commented on HDFS-5003: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk #1464 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1464/]) HDFS-5003. TestNNThroughputBenchmark failed caused by existing directories. Contributed by Xi Fang. (cnauroth: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1504352) * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/NNThroughputBenchmark.java > TestNNThroughputBenchmark failed caused by existing directories > --------------------------------------------------------------- > > Key: HDFS-5003 > URL: https://issues.apache.org/jira/browse/HDFS-5003 > Project: Hadoop HDFS > Issue Type: Bug > Components: test > Affects Versions: 3.0.0, 1-win, 2.1.0-beta, 1.3.0 > Reporter: Xi Fang > Assignee: Xi Fang > Priority: Minor > Fix For: 3.0.0, 1-win, 2.1.0-beta, 1.3.0 > > Attachments: HADOOP-9739.1.patch, HADOOP-9739.1.trunk.patch > > > This test failed on both Windows and Linux. > Here is the error information. > Testcase: testNNThroughput took 36.221 sec > Caused an ERROR > NNThroughputBenchmark: cannot mkdir D:\condor\condor\build\test\dfs\hosts\exclude > java.io.IOException: NNThroughputBenchmark: cannot mkdir D:\condor\condor\build\test\dfs\hosts\exclude > at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.(NNThroughputBenchmark.java:111) > at org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.runBenchmark(NNThroughputBenchmark.java:1168) > at org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark.testNNThroughput(TestNNThroughputBenchmark.java:38) > This test may not fail for the first run, but will fail for the second one. > The root cause is in the constructor of NNThroughputBenchmark > {code} > NNThroughputBenchmark(Configuration conf) throws IOException, LoginException { > ... > config.set("dfs.hosts.exclude", "${hadoop.tmp.dir}/dfs/hosts/exclude"); > File excludeFile = new File(config.get("dfs.hosts.exclude", "exclude")); > if(! excludeFile.exists()) { > if(!excludeFile.getParentFile().mkdirs()) > throw new IOException("NNThroughputBenchmark: cannot mkdir " + excludeFile); > } > new FileOutputStream(excludeFile).close(); > {code} > excludeFile.getParentFile() may already exist, then excludeFile.getParentFile().mkdirs() will return false, which however is not an expected behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira