Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 50D09108B4 for ; Mon, 15 Jul 2013 22:52:50 +0000 (UTC) Received: (qmail 39780 invoked by uid 500); 15 Jul 2013 22:52:50 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 39743 invoked by uid 500); 15 Jul 2013 22:52:50 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 39734 invoked by uid 99); 15 Jul 2013 22:52:50 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 15 Jul 2013 22:52:50 +0000 Date: Mon, 15 Jul 2013 22:52:49 +0000 (UTC) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4979) Implement retry cache on the namenode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709105#comment-13709105 ] Suresh Srinivas commented on HDFS-4979: --------------------------------------- I noticed that where I am setting boolean {{success}} to true in try blocks is susceptible to issues related to reordered writes. I am going to change them to AtomicBoolean in my next patch. Any one wants to take a stab at reviewing this patch? bq. The above two cases are different because the return type is a comprehensive object. Hence instead of storing the object in retry cache, it is generated during retry attempts. In the following cases, return type is a simple object. Hence it results in simple handling with just void, string or boolean returned. In order to save some memory, should we order complexity or just hold on to the previous response? Thoughts? > Implement retry cache on the namenode > ------------------------------------- > > Key: HDFS-4979 > URL: https://issues.apache.org/jira/browse/HDFS-4979 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: namenode > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Attachments: HDFS-4979.1.patch, HDFS-4979.2.patch, HDFS-4979.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira