Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 10 Jul 2013 18:03:49 +0000 (UTC)
From: "Chris Nauroth (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12656962.1373409465580.27129.1373479429183@arcas>
In-Reply-To: <JIRA.12656962.1373409465580@arcas>
References: <JIRA.12656962.1373409465580@arcas>
Subject: [jira] [Moved] (HDFS-4975) Branch-1-win TestReplicationPolicy
 failed caused by stale data node handling
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-4975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth moved HADOOP-9714 to HDFS-4975:
---------------------------------------------

        Fix Version/s:     (was: 1-win)
                       1-win
    Affects Version/s:     (was: 1-win)
                       1-win
                  Key: HDFS-4975  (was: HADOOP-9714)
              Project: Hadoop HDFS  (was: Hadoop Common)
    
> Branch-1-win TestReplicationPolicy failed caused by stale data node handling
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-4975
>                 URL: https://issues.apache.org/jira/browse/HDFS-4975
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 1-win
>            Reporter: Xi Fang
>            Assignee: Xi Fang
>             Fix For: 1-win
>
>         Attachments: HADOOP-9714.1.patch
>
>
> TestReplicationPolicy failed on 
> * testChooseTargetWithMoreThanAvailableNodes()
> * testChooseTargetWithStaleNodes()
> * testChooseTargetWithHalfStaleNodes()
> The root of cause of testChooseTargetWithMoreThanAvailableNodes failing is the following:
> In BlockPlacementPolicyDefault#chooseTarget()
> {code}
>   chooseRandom(numOfReplicas, NodeBase.ROOT, excludedNodes, 
>         blocksize, maxNodesPerRack, results);
>     } catch (NotEnoughReplicasException e) {
>       FSNamesystem.LOG.warn("Not able to place enough replicas, still in need of " + numOfReplicas);
> {code}
> However, numOfReplicas is passed into chooseRandom() as int (primitive type in java) by value. The updating operation for numOfReplicas in chooseRandom() will not change the value in chooseTarget(). 
> The root cause for testChooseTargetWithStaleNodes() and testChooseTargetWithHalfStaleNodes() is the current BlockPlacementPolicyDefault#chooseTarget() doesn't check if a node is stale.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira