Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D53C110463 for ; Tue, 9 Jul 2013 23:01:51 +0000 (UTC) Received: (qmail 48828 invoked by uid 500); 9 Jul 2013 23:01:51 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 48793 invoked by uid 500); 9 Jul 2013 23:01:51 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 48784 invoked by uid 99); 9 Jul 2013 23:01:51 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 09 Jul 2013 23:01:51 +0000 Date: Tue, 9 Jul 2013 23:01:51 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4816) transitionToActive blocks if the SBN is doing checkpoint image transfer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703951#comment-13703951 ] Hadoop QA commented on HDFS-4816: --------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12589793/hdfs-4816-4.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4614//testReport/ Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4614//console This message is automatically generated. > transitionToActive blocks if the SBN is doing checkpoint image transfer > ----------------------------------------------------------------------- > > Key: HDFS-4816 > URL: https://issues.apache.org/jira/browse/HDFS-4816 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 3.0.0, 2.0.4-alpha > Reporter: Andrew Wang > Assignee: Andrew Wang > Attachments: hdfs-4816-1.patch, hdfs-4816-2.patch, hdfs-4816-3.patch, hdfs-4816-4.patch, hdfs-4816-slow-shutdown.txt, stacks.out > > > The NN and SBN do this dance during checkpoint image transfer with nested HTTP GETs via {{HttpURLConnection}}. When an admin does a {{-transitionToActive}} during this transfer, part of that is interrupting an ongoing checkpoint so we can transition immediately. > However, the {{thread.interrupt()}} in {{StandbyCheckpointer#stop}} gets swallowed by {{connection.getResponseCode()}} in {{TransferFsImage#doGetUrl}}. None of the methods in HttpURLConnection throw InterruptedException, so we need to do something else (perhaps HttpClient [1]): > [1]: http://hc.apache.org/httpclient-3.x/ -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira