Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F09C010CD0 for ; Mon, 1 Jul 2013 14:09:27 +0000 (UTC) Received: (qmail 65066 invoked by uid 500); 1 Jul 2013 14:09:26 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 65017 invoked by uid 500); 1 Jul 2013 14:09:22 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 64988 invoked by uid 99); 1 Jul 2013 14:09:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 01 Jul 2013 14:09:20 +0000 Date: Mon, 1 Jul 2013 14:09:20 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4797) BlockScanInfo does not override equals(..) and hashCode() consistently MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696834#comment-13696834 ] Hudson commented on HDFS-4797: ------------------------------ Integrated in Hadoop-Mapreduce-trunk #1474 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1474/]) HDFS-4797. BlockScanInfo does not override equals(..) and hashCode() consistently. (Revision 1498202) Result = SUCCESS szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498202 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java > BlockScanInfo does not override equals(..) and hashCode() consistently > ---------------------------------------------------------------------- > > Key: HDFS-4797 > URL: https://issues.apache.org/jira/browse/HDFS-4797 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Priority: Minor > Fix For: 2.2.0 > > Attachments: h4797_20130513b.patch, h4797_20130513.patch > > > In the code below, equals(..) compares lastScanTime but hashCode() is computed using block ID. Therefore, it could have two BlockScanInfo objects which are equal but have two different hash codes. > {code} > //BlockScanInfo > @Override > public int hashCode() { > return block.hashCode(); > } > > @Override > public boolean equals(Object other) { > return other instanceof BlockScanInfo && > compareTo((BlockScanInfo)other) == 0; > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira