hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-5007) the property key "dfs.http.port" and "dfs.https.port" are hard corded
Date Fri, 19 Jul 2013 04:04:49 GMT

    [ https://issues.apache.org/jira/browse/HDFS-5007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13713318#comment-13713318

Hadoop QA commented on HDFS-5007:

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:


    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4688//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4688//console

This message is automatically generated.
> the property key "dfs.http.port" and "dfs.https.port" are hard corded
> ---------------------------------------------------------------------
>                 Key: HDFS-5007
>                 URL: https://issues.apache.org/jira/browse/HDFS-5007
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Kousuke Saruta
>            Assignee: Kousuke Saruta
>             Fix For: 3.0.0
>         Attachments: HDFS-5007.patch, HDFS-5007.patch, HDFS-5007.patch
> In "TestHftpFileSystem.java" and "NameNodeHttpServer.java" , the two property key "dfs.http.port"
and "dfs.https.port" are hard corded.
> Now, the constant values "DFS_NAMENODE_HTTP_PORT_KEY" and "DFS_NAMENODE_HTTPS_KEY" in
DFSConfigKeys are available so I think we should replace those for maintainability. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message