hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4996) ClientProtocol#metaSave can be made idempotent by overwriting the output file instead of appending to it
Date Thu, 18 Jul 2013 20:46:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13712809#comment-13712809
] 

Hadoop QA commented on HDFS-4996:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12593022/HDFS-4996.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-common-project/hadoop-common
hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4684//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4684//console

This message is automatically generated.
                
> ClientProtocol#metaSave can be made idempotent by overwriting the output file instead
of appending to it
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4996
>                 URL: https://issues.apache.org/jira/browse/HDFS-4996
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Minor
>         Attachments: HDFS-4996.1.patch, HDFS-4996.2.patch
>
>
> {{ClientProtocol#metaSave}} opens its output file for append.  This prevents the operation
from being idempotent, because retries can cause unpredictable side effects (single copy of
the output vs. multiple copies).  As discussed on HDFS-4974, the operation could be made idempotent
by changing this to open the file for overwrite instead of append.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message