hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4978) Make disallowSnapshot idempotent
Date Thu, 11 Jul 2013 18:39:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706099#comment-13706099

Suresh Srinivas commented on HDFS-4978:

+1 for the patch. Can you add @Idempotent annotation to disallowSnapshot() method. Also can
you add @Idempotent flag to allowSnapshot (with a unit test to ensure this) and getSnapshotDiffReport.
I am okay if you want to handle the second comment in a separate jira.
> Make disallowSnapshot idempotent
> --------------------------------
>                 Key: HDFS-4978
>                 URL: https://issues.apache.org/jira/browse/HDFS-4978
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>         Attachments: HDFS-4978.001.patch, HDFS-4978.002.patch, HDFS-4978.003.patch
> Currently disallowSnapshot is not idempotent: an exception will be thrown when the directory
is already non-snapshottable. This jira tries to make it idempotent.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message