hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jing Zhao (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4962) Use enum for nfs constants
Date Tue, 09 Jul 2013 17:47:49 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13703552#comment-13703552
] 

Jing Zhao commented on HDFS-4962:
---------------------------------

For the fromValue(int) methods, do we need to handle invalid inputs? For example, for NFSPROC3,
originally if the integer read from the request is invalid (not in range [0, 21]), an error
msg will be send back. Now we may get a runtime exception in the server side. Similar for
other enums like RpcMessage.Type.
                
> Use enum for nfs constants
> --------------------------
>
>                 Key: HDFS-4962
>                 URL: https://issues.apache.org/jira/browse/HDFS-4962
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4962_20130709b.patch, h4962_20130709.patch
>
>
> The constants defined in MountInterface and some other classes are better to use enum
types instead of lists of int.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message