hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brandon Li (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4962) Use enum for nfs constants
Date Wed, 31 Jul 2013 23:19:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725817#comment-13725817
] 

Brandon Li commented on HDFS-4962:
----------------------------------

[~szetszwo]:{quote}h4962_20130710.patch: returns null if the value is out of range; and changes
switch() back to if-then since switch() cannot handle null.{quote}
PortmapInterface.java doesn't have this out of range check.
                
> Use enum for nfs constants
> --------------------------
>
>                 Key: HDFS-4962
>                 URL: https://issues.apache.org/jira/browse/HDFS-4962
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: nfs
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 3.0.0
>
>         Attachments: h4962_20130709b.patch, h4962_20130709.patch, h4962_20130710b.patch,
h4962_20130710.patch
>
>
> The constants defined in MountInterface and some other classes are better to use enum
types instead of lists of int.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message