hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vivek Ganesan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4926) namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link
Date Fri, 12 Jul 2013 17:41:50 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707133#comment-13707133
] 

Vivek Ganesan commented on HDFS-4926:
-------------------------------------

    {color:red}-1 overall{color}.  

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 43 warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.
=====================================================================================================

No tests included because the change was a minor change involving a display value in a web
page.  No similar previous tests were found.

Created a distribution and verified in a pseudo cluster.

Steps:

1. Start DFS -> start-dfs.sh
2. In browser, navigate to http://localhost:50070/dfsnodelist.jsp?whatNodes=LIVE
3. Hover the mouse pointer over any node name and check if it displays hostname:port rather
than ipAddress:port

======================================================================================================

javadoc warnings are not related to the changes made. please find attached file specifying
javadoc warnings



                
> namenode webserver's page has a tooltip that is inconsistent with the datanode HTML link
> ----------------------------------------------------------------------------------------
>
>                 Key: HDFS-4926
>                 URL: https://issues.apache.org/jira/browse/HDFS-4926
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Joseph Lorenzini
>            Assignee: Vivek Ganesan
>            Priority: Trivial
>         Attachments: hdfs-4926.patch
>
>
> At http://localhost:50070/dfsnodelist.jsp?whatNodes=LIVE, there is a list of Live datanodes
in a table.  In the Node column, there is a link to each node. If you hover your cursor over
one of the links, it shows the IP address and port number of the datanode. However, actual
link is the hostname instead of the IP. 
> Suggest that the tooltip reflect the actual url that the web browser would go to if the
link is selected.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message