hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4797) BlockScanInfo does not override equals(..) and hashCode() consistently
Date Thu, 11 Jul 2013 00:27:51 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alejandro Abdelnur updated HDFS-4797:
-------------------------------------

    Fix Version/s:     (was: 2.2.0)
                   2.1.0-beta
    
> BlockScanInfo does not override equals(..) and hashCode() consistently
> ----------------------------------------------------------------------
>
>                 Key: HDFS-4797
>                 URL: https://issues.apache.org/jira/browse/HDFS-4797
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 2.1.0-beta
>
>         Attachments: h4797_20130513b.patch, h4797_20130513.patch
>
>
> In the code below, equals(..) compares lastScanTime but hashCode() is computed using
block ID.  Therefore, it could have two BlockScanInfo objects which are equal but have two
different hash codes.
> {code}
> //BlockScanInfo
>     @Override
>     public int hashCode() {
>       return block.hashCode();
>     }
>     
>     @Override
>     public boolean equals(Object other) {
>       return other instanceof BlockScanInfo &&
>              compareTo((BlockScanInfo)other) == 0;
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message