hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4797) BlockScanInfo does not override equals(..) and hashCode() consistently
Date Mon, 01 Jul 2013 14:09:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696834#comment-13696834
] 

Hudson commented on HDFS-4797:
------------------------------

Integrated in Hadoop-Mapreduce-trunk #1474 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1474/])
    HDFS-4797. BlockScanInfo does not override equals(..) and hashCode() consistently. (Revision
1498202)

     Result = SUCCESS
szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498202
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolSliceScanner.java

                
> BlockScanInfo does not override equals(..) and hashCode() consistently
> ----------------------------------------------------------------------
>
>                 Key: HDFS-4797
>                 URL: https://issues.apache.org/jira/browse/HDFS-4797
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: h4797_20130513b.patch, h4797_20130513.patch
>
>
> In the code below, equals(..) compares lastScanTime but hashCode() is computed using
block ID.  Therefore, it could have two BlockScanInfo objects which are equal but have two
different hash codes.
> {code}
> //BlockScanInfo
>     @Override
>     public int hashCode() {
>       return block.hashCode();
>     }
>     
>     @Override
>     public boolean equals(Object other) {
>       return other instanceof BlockScanInfo &&
>              compareTo((BlockScanInfo)other) == 0;
>     }
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message