hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4325) ClientProtocol.createSymlink parameter dirPerm invalid
Date Thu, 25 Jul 2013 11:09:49 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719501#comment-13719501
] 

Hadoop QA commented on HDFS-4325:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12594139/HDFS-4325.v1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4730//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4730//console

This message is automatically generated.
                
> ClientProtocol.createSymlink parameter dirPerm invalid
> ------------------------------------------------------
>
>                 Key: HDFS-4325
>                 URL: https://issues.apache.org/jira/browse/HDFS-4325
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client, namenode
>    Affects Versions: 2.0.4-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4325.v1.patch
>
>
> {code}
>    * @param link The path of the link being created.
>    * @param dirPerm permissions to use when creating parent directories
>    * @param createParent - if true then missing parent dirs are created
>    *                       if false then parent must exist
> {code}
> According to javadoc, auto created parent dir's permissions will be dirPerm, but in fact
directory permissions are always inherit from parent directory plus u+wx.
> IMHO, createSymlink behavior should be the same as create, which also inherit parent
dir permission, so the current behavior makes sense, but the related dirPerm parameters should
be removed cause it is invalid and confusing. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message