hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Binglin Chang (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4325) ClientProtocol.createSymlink parameter dirPerm invalid
Date Thu, 25 Jul 2013 09:03:51 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Binglin Chang updated HDFS-4325:

    Attachment: HDFS-4325.v1.patch

Because ClientProtocol is in RPC and param dirPerm is defined as "required" in proto files,
I am not sure whether or not to remove it, so I just add some comments to clarify this parameter
is invalid, and do some minor modification in server side.

> ClientProtocol.createSymlink parameter dirPerm invalid
> ------------------------------------------------------
>                 Key: HDFS-4325
>                 URL: https://issues.apache.org/jira/browse/HDFS-4325
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client, namenode
>    Affects Versions: 2.0.4-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>         Attachments: HDFS-4325.v1.patch
> {code}
>    * @param link The path of the link being created.
>    * @param dirPerm permissions to use when creating parent directories
>    * @param createParent - if true then missing parent dirs are created
>    *                       if false then parent must exist
> {code}
> According to javadoc, auto created parent dir's permissions will be dirPerm, but in fact
directory permissions are always inherit from parent directory plus u+wx.
> IMHO, createSymlink behavior should be the same as create, which also inherit parent
dir permission, so the current behavior makes sense, but the related dirPerm parameters should
be removed cause it is invalid and confusing. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message