Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 17 Jun 2013 09:59:21 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12653070.1371396456778.124616.1371463161469@arcas>
In-Reply-To: <JIRA.12653070.1371396456778@arcas>
References: <JIRA.12653070.1371396456778@arcas>
Subject: [jira] [Commented] (HDFS-4908) Reduce snapshot inode memory usage
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13685412#comment-13685412 ] 

Hadoop QA commented on HDFS-4908:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12588110/h4908_20130617c.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4526//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4526//console

This message is automatically generated.
                
> Reduce snapshot inode memory usage
> ----------------------------------
>
>                 Key: HDFS-4908
>                 URL: https://issues.apache.org/jira/browse/HDFS-4908
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode, snapshots
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 2.1.0-beta
>
>         Attachments: editsStored, h4908_20130617b.patch, h4908_20130617c.patch, h4908_20130617.patch
>
>
> Snapshots currently use INodeFile and INodeDirectory for storing previous file/dir states as snapshot inodes.  However, INodeFile and INodeDirectory have some fields not used by snapshot inodes such as parent reference, inode id, block/children reference.  The memory footprint could be reduced by having some specific classes for snapshot inodes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira