Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 4 Jun 2013 00:08:20 +0000 (UTC)
From: "Ravi Prakash (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12649811.1369781732028.60829.1370304500113@arcas>
In-Reply-To: <JIRA.12649811.1369781732028@arcas>
References: <JIRA.12649811.1369781732028@arcas>
Subject: [jira] [Updated] (HDFS-4862) SafeModeInfo.isManual() returns true
 when resources are low even if it wasn't entered into manually
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-4862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ravi Prakash updated HDFS-4862:
-------------------------------

    Attachment: HDFS-4862.patch

Hi Kihwal! There already exists a method to check for low resources (areResourcesLow()). So I don't understand why we need to club that in isManual. To me isManual clearly means that the safemode was entered into manually. Moreover I could also argue that the NN should be taken out of low-resource safemode automatically when ResourceMonitor detects adequate resources, so it may not necessarily be a manual step. 
This is a patch which IMHO corrects these behaviors. Could you please review it?
                
> SafeModeInfo.isManual() returns true when resources are low even if it wasn't entered into manually
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4862
>                 URL: https://issues.apache.org/jira/browse/HDFS-4862
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.0.0, 0.23.7, 2.0.4-alpha
>            Reporter: Ravi Prakash
>         Attachments: HDFS-4862.patch
>
>
> HDFS-1594 changed isManual to this
> {code}
> private boolean isManual() {
>   return extension == Integer.MAX_VALUE && !resourcesLow;
> }
> {code}
> One immediate impact of this is that when resources are low, the NN will throw away all block reports from DNs. This is undesirable.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira