Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 5 Jun 2013 13:05:24 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12647139.1368231650830.71221.1370437524359@arcas>
In-Reply-To: <JIRA.12647139.1368231650830@arcas>
References: <JIRA.12647139.1368231650830@arcas>
Subject: [jira] [Commented] (HDFS-4815)
 TestRBWBlockInvalidation#testBlockInvalidationWhenRBWReplicaMissedInDN:
 Double call countReplicas() to fetch corruptReplicas and liveReplicas is
 not needed
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13675888#comment-13675888 ] 

Hudson commented on HDFS-4815:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1421 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1421/])
    HDFS-4815. TestRBWBlockInvalidation: Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed. Contributed by Tian Hong Wang. (Revision 1489668)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1489668
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestRBWBlockInvalidation.java

                
> TestRBWBlockInvalidation#testBlockInvalidationWhenRBWReplicaMissedInDN: Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4815
>                 URL: https://issues.apache.org/jira/browse/HDFS-4815
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: datanode, test
>            Reporter: Tian Hong Wang
>            Assignee: Tian Hong Wang
>              Labels: patch
>             Fix For: 2.1.0-beta
>
>         Attachments: HDFS-4815.patch
>
>
> In TestRBWBlockInvalidation, the original code is:
> while (!isCorruptReported) {
>         if (countReplicas(namesystem, blk).corruptReplicas() > 0) {
>           isCorruptReported = true;
>         }
>         Thread.sleep(100);
> }
> assertEquals("There should be 1 replica in the corruptReplicasMap", 1,
>           countReplicas(namesystem, blk).corruptReplicas());
> Once the program detects there exists one corruptReplica, it will break the while loop. After that, it call countReplicas() again in assertEquals(). But sometimes I met the following error:
> java.lang.AssertionError: There should be 1 replica in the corruptReplicasMap expected:<1> but was:<0>
> It's obviously that second function call countReplicas() in assertEquals(), the corruptReplicas value has been changed since program go to sleep and BlockManger recovered the corrupt block during this sleep time.  
> So what I do is:
> 1) once detecting there exists one corruptReplica, break the loop and don't call sleep(), the same as liveReplicas
> 2) don't double check the countReplicas & liveReplicas in assertEquals()
> 3) sometimes I meet the problem of testcase timeout, so I speed up the block report interval

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira