hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Colin Patrick McCabe (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4914) When possible, Use DFSClient.Conf instead of Configuration
Date Wed, 19 Jun 2013 17:42:21 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688198#comment-13688198
] 

Colin Patrick McCabe commented on HDFS-4914:
--------------------------------------------

{code}
-  private static final Log LOG = LogFactory.getLog(DFSClient.class);
+  private static final Log LOG = BlockReaderLocal.LOG;
{code}

Why not give BlockReaderLocalLegacy its own LOG object?  It seems confusing to combine the
two.

The rest of the patch looks fine.
                
> When possible, Use DFSClient.Conf instead of Configuration 
> -----------------------------------------------------------
>
>                 Key: HDFS-4914
>                 URL: https://issues.apache.org/jira/browse/HDFS-4914
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: hdfs-client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h4914_20130618.patch, h4914_20130619.patch
>
>
> In DFSClient and the related classes, we should use DFSClient.Conf instead of Configuration.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message