hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4906) HDFS Output streams should not accept writes after being closed
Date Mon, 17 Jun 2013 18:05:22 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Aaron T. Myers updated HDFS-4906:
---------------------------------

    Attachment: HDFS-4906.patch

Thanks a lot for the review, Steve. In the latest patch I've switched to using ClosedChannelException.

I didn't do anything to address your second comment, since DFSOutputStream#close is already
synchronized, and the two other relevant close() methods in ChecksumFileSystem and ChecksumFs
are in classes which appear to make no attempt at synchronization at all.

Does this look reasonable to you?
                
> HDFS Output streams should not accept writes after being closed
> ---------------------------------------------------------------
>
>                 Key: HDFS-4906
>                 URL: https://issues.apache.org/jira/browse/HDFS-4906
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.0.5-alpha
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>         Attachments: HDFS-4906.patch, HDFS-4906.patch, HDFS-4906.patch
>
>
> Currently if one closes an OutputStream obtained from FileSystem#create and then calls
write(...) on that closed stream, the write will appear to succeed without error though no
data will be written to HDFS. A subsequent call to close will also silently appear to succeed.
We should make it so that attempts to write to closed streams fails fast.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message