hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4765) Permission check of symlink deletion incorrectly throws UnresolvedLinkException
Date Sat, 22 Jun 2013 12:42:22 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13691128#comment-13691128
] 

Hudson commented on HDFS-4765:
------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #646 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/646/])
    HDFS-4765. Permission check of symlink deletion incorrectly throws UnresolvedLinkException.
Contributed by Andrew Wang (Revision 1495603)

     Result = SUCCESS
jlowe : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495603
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSPermissionChecker.java
* /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/security/TestPermission.java

                
> Permission check of symlink deletion incorrectly throws UnresolvedLinkException
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4765
>                 URL: https://issues.apache.org/jira/browse/HDFS-4765
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.0.3-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>             Fix For: 2.1.0-beta, 0.23.9
>
>         Attachments: hdfs-4765-1.patch, hdfs-4765-2.patch, hdfs-4765-branch-0.23.patch,
hdfs-4765-branch-2-1.patch
>
>
> With permissions enabled, the permission check in {{FSNamesystem#delete}} will incorrectly
throw an UnresolvedLinkException if the path contains a symlink. This leads to FileContext
resolving the symlink and instead deleting the link target.
> The correct check is to see if the user has write permissions on the parent directory
of the symlink, e.g.
> {noformat}
> -> % ls -ld symtest
> drwxr-xr-x 2 root root 4096 Apr 26 14:12 symtest
> -> % ls -l symtest
> total 12
> lrwxrwxrwx 1 root root 6 Apr 26 14:12 link -> target
> -rw-r--r-- 1 root root 0 Apr 26 14:11 target
> -> % rm -f symtest/link
> rm: cannot remove `symtest/link': Permission denied
> -> % sudo chown andrew symtest
> -> % rm -f symtest/link       
> -> % 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message