Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6C757E12A for ; Wed, 29 May 2013 22:24:22 +0000 (UTC) Received: (qmail 69153 invoked by uid 500); 29 May 2013 22:24:22 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 69122 invoked by uid 500); 29 May 2013 22:24:22 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 69107 invoked by uid 99); 29 May 2013 22:24:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 May 2013 22:24:22 +0000 Date: Wed, 29 May 2013 22:24:21 +0000 (UTC) From: "Jing Zhao (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HDFS-4857) Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap when loading FSImage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jing Zhao updated HDFS-4857: ---------------------------- Resolution: Fixed Fix Version/s: 3.0.0 Status: Resolved (was: Patch Available) I've committed this. Thanks for the review Nicholas! > Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap when loading FSImage > ------------------------------------------------------------------------------------------------------ > > Key: HDFS-4857 > URL: https://issues.apache.org/jira/browse/HDFS-4857 > Project: Hadoop HDFS > Issue Type: Bug > Components: snapshots > Affects Versions: 3.0.0 > Reporter: Jing Zhao > Assignee: Jing Zhao > Labels: snapshots > Fix For: 3.0.0 > > Attachments: HDFS-4857.001.patch, HDFS-4857.002.patch > > > Snapshot.Root, though is a subclass of INodeDirectory, is only used to indicate the root of a snapshot. In the meanwhile, AbstractINodeDiff#snapshotINode is used as copies recording the original state of an INode. Thus we should not put them into INodeMap. > Currently when loading FSImage we did not check the type of inode and wrongly put these two types of nodes into INodeMap. This may replace the nodes that should stay in INodeMap. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira