Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1C884DB6A for ; Mon, 27 May 2013 14:59:24 +0000 (UTC) Received: (qmail 97263 invoked by uid 500); 27 May 2013 14:59:23 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 96315 invoked by uid 500); 27 May 2013 14:59:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 95993 invoked by uid 99); 27 May 2013 14:59:20 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 May 2013 14:59:20 +0000 Date: Mon, 27 May 2013 14:59:20 +0000 (UTC) From: "Vinay (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (HDFS-4855) DFSOutputStream reference should be cleared from DFSClient#filesBeingWritten if the file closure fails. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Vinay created HDFS-4855: --------------------------- Summary: DFSOutputStream reference should be cleared from DFSClient#filesBeingWritten if the file closure fails. Key: HDFS-4855 URL: https://issues.apache.org/jira/browse/HDFS-4855 Project: Hadoop HDFS Issue Type: Bug Components: hdfs-client Affects Versions: 2.0.4-alpha Reporter: Vinay Assignee: Vinay Fix For: 2.0.4.1-alpha If the file closure fails due to some exception, then {{DFSOutputStream}} reference should be removed from the {{DFSClient#filesBeingWritten}}. Which is useless to keep and also memory consuming. If the same client is being used for long time,, then there is a chance of client getting OOM due to this. fix would be simple. Just cover complete {{DFSOutputStream#close()}} under try-finally and move {{dfsClient.endFileLease(src);}} to finally block. Any thoughts..? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira