Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F026BDDAF for ; Thu, 16 May 2013 00:05:16 +0000 (UTC) Received: (qmail 40561 invoked by uid 500); 16 May 2013 00:05:16 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 40530 invoked by uid 500); 16 May 2013 00:05:16 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 40521 invoked by uid 99); 16 May 2013 00:05:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 May 2013 00:05:16 +0000 Date: Thu, 16 May 2013 00:05:16 +0000 (UTC) From: "Tian Hong Wang (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4815) TestRBWBlockInvalidation#testBlockInvalidationWhenRBWReplicaMissedInDN: Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13659057#comment-13659057 ] Tian Hong Wang commented on HDFS-4815: -------------------------------------- Thanks Chris for your comment. > TestRBWBlockInvalidation#testBlockInvalidationWhenRBWReplicaMissedInDN: Double call countReplicas() to fetch corruptReplicas and liveReplicas is not needed > ----------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HDFS-4815 > URL: https://issues.apache.org/jira/browse/HDFS-4815 > Project: Hadoop HDFS > Issue Type: Bug > Components: datanode, test > Reporter: Tian Hong Wang > Assignee: Tian Hong Wang > Labels: patch > Attachments: HDFS-4815.patch > > > In TestRBWBlockInvalidation, the original code is: > while (!isCorruptReported) { > if (countReplicas(namesystem, blk).corruptReplicas() > 0) { > isCorruptReported = true; > } > Thread.sleep(100); > } > assertEquals("There should be 1 replica in the corruptReplicasMap", 1, > countReplicas(namesystem, blk).corruptReplicas()); > Once the program detects there exists one corruptReplica, it will break the while loop. After that, it call countReplicas() again in assertEquals(). But sometimes I met the following error: > java.lang.AssertionError: There should be 1 replica in the corruptReplicasMap expected:<1> but was:<0> > It's obviously that second function call countReplicas() in assertEquals(), the corruptReplicas value has been changed since program go to sleep and BlockManger recovered the corrupt block during this sleep time. > So what I do is: > 1) once detecting there exists one corruptReplica, break the loop and don't call sleep(), the same as liveReplicas > 2) don't double check the countReplicas & liveReplicas in assertEquals() > 3) sometimes I meet the problem of testcase timeout, so I speed up the block report interval -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira