Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Tue, 7 May 2013 17:03:16 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12646422.1367939470902.281868.1367946196198@arcas>
In-Reply-To: <JIRA.12646422.1367939470902@arcas>
References: <JIRA.12646422.1367939470902@arcas>
Subject: [jira] [Commented] (HDFS-4804) WARN when users set the block
 balanced preference percent below 0.5 or above 1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651061#comment-13651061 ] 

Hadoop QA commented on HDFS-4804:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12582108/HDFS-4804.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4362//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4362//console

This message is automatically generated.
                
> WARN when users set the block balanced preference percent below 0.5 or above 1.0
> --------------------------------------------------------------------------------
>
>                 Key: HDFS-4804
>                 URL: https://issues.apache.org/jira/browse/HDFS-4804
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 2.0.4-alpha
>            Reporter: Stephen Chu
>            Assignee: Stephen Chu
>            Priority: Minor
>         Attachments: HDFS-4804.patch
>
>
> With the new feature added in HDFS-1804 (Add a new block-volume device choosing policy that looks at free space), it'd be useful to have a WARN log if the operator  sets dfs.datanode.fsdataset.volume.choosing.balanced-space-preference-percent to a value greater than 1.0. This might happen if the operator mistakenly assumes that this setting takes in a percentage number from 0.0-100.0, while the setting actually takes a range 0.0-1.0.
> Also, it'd be useful to WARN in the case that value is set below 0.5, which would cause disks with less free space to get more block allocations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira