Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 29 May 2013 18:46:22 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12615062.1352254638303.36917.1369853182489@arcas>
In-Reply-To: <JIRA.12615062.1352254638303@arcas>
References: <JIRA.12615062.1352254638303@arcas>
Subject: [jira] [Commented] (HDFS-4160) libhdfs / fuse-dfs should implement
 O_CREAT | O_EXCL
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13669558#comment-13669558 ] 

Hadoop QA commented on HDFS-4160:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12585242/HDFS-4160.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4451//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4451//console

This message is automatically generated.
                
> libhdfs / fuse-dfs should implement O_CREAT | O_EXCL
> ----------------------------------------------------
>
>                 Key: HDFS-4160
>                 URL: https://issues.apache.org/jira/browse/HDFS-4160
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 2.0.3-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HDFS-4160.001.patch
>
>
> {{hdfsOpenFile}} contains this code:
> {code}
> if ((flags & O_CREAT) && (flags & O_EXCL)) {                               
>   fprintf(stderr, "WARN: hdfs does not truly support O_CREATE && O_EXCL\n");
> } 
> {code}
> But {{hdfsOpenFile}} could easily support *O_CREAT* | *O_EXCL* by calling {{FileSystem#create}} with {{overwrite = false}}.
> We should do this.  It would also benefit {{fuse-dfs}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira