hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4857) Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap when loading FSImage
Date Thu, 30 May 2013 13:15:24 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13670320#comment-13670320
] 

Hudson commented on HDFS-4857:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1415 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1415/])
    HDFS-4857. Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap
when loading FSImage. Contributed by Jing Zhao (Revision 1487655)

     Result = FAILURE
jing9 : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1487655
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSImageFormat.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/Snapshot.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotFSImageFormat.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestFSImageWithSnapshot.java

                
> Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap when
loading FSImage
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4857
>                 URL: https://issues.apache.org/jira/browse/HDFS-4857
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>              Labels: snapshots
>             Fix For: 3.0.0
>
>         Attachments: HDFS-4857.001.patch, HDFS-4857.002.patch
>
>
> Snapshot.Root, though is a subclass of INodeDirectory, is only used to indicate the root
of a snapshot. In the meanwhile, AbstractINodeDiff#snapshotINode is used as copies recording
the original state of an INode. Thus we should not put them into INodeMap. 
> Currently when loading FSImage we did not check the type of inode and wrongly put these
two types of nodes into INodeMap. This may replace the nodes that should stay in INodeMap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message