hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4857) Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap when loading FSImage
Date Tue, 28 May 2013 04:50:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668093#comment-13668093
] 

Hadoop QA commented on HDFS-4857:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12584991/HDFS-4857.001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:

                  org.apache.hadoop.hdfs.server.blockmanagement.TestBlocksWithNotEnoughRacks

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4442//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4442//console

This message is automatically generated.
                
> Snapshot.Root and AbstractINodeDiff#snapshotINode should not be put into INodeMap when
loading FSImage
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-4857
>                 URL: https://issues.apache.org/jira/browse/HDFS-4857
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: snapshots
>    Affects Versions: 3.0.0
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>              Labels: snapshots
>         Attachments: HDFS-4857.001.patch
>
>
> Snapshot.Root, though is a subclass of INodeDirectory, is only used to indicate the root
of a snapshot. In the meanwhile, AbstractINodeDiff#snapshotINode is used as copies recording
the original state of an INode. Thus we should not put them into INodeMap. 
> Currently when loading FSImage we did not check the type of inode and wrongly put these
two types of nodes into INodeMap. This may replace the nodes that should stay in INodeMap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message