hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4824) FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner
Date Fri, 17 May 2013 01:50:13 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13660253#comment-13660253
] 

Hadoop QA commented on HDFS-4824:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12583591/HDFS-4824.002.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified
tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4411//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4411//console

This message is automatically generated.
                
> FileInputStreamCache.close leaves dangling reference to FileInputStreamCache.cacheCleaner
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-4824
>                 URL: https://issues.apache.org/jira/browse/HDFS-4824
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs-client
>    Affects Versions: 2.0.4-alpha
>            Reporter: Henry Robinson
>            Assignee: Colin Patrick McCabe
>         Attachments: HDFS-4824.001.patch, HDFS-4824.002.patch
>
>
> {{FileInputStreamCache}} leaves around a reference to its {{cacheCleaner}} after {{close()}}.
> The {{cacheCleaner}} is created like this:
> {code}
> if (cacheCleaner == null) {
>           cacheCleaner = new CacheCleaner();
>           executor.scheduleAtFixedRate(cacheCleaner, expiryTimeMs, expiryTimeMs,
>               TimeUnit.MILLISECONDS);
>         }
> {code}
> and supposedly removed like this:
> {code}
> if (cacheCleaner != null) {
>   executor.remove(cacheCleaner);
> }
> {code}
> However, {{ScheduledThreadPoolExecutor.remove}} returns a success boolean which should
be checked. And I _think_ from a quick read of that class that the return value of {{scheduleAtFixedRate}}
should be used as the argument to {{remove}}. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message