hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4787) Create a new HdfsConfiguration before each TestDFSClientRetries testcases
Date Tue, 07 May 2013 23:13:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651415#comment-13651415
] 

Chris Nauroth commented on HDFS-4787:
-------------------------------------

Sorry, Tian.  I just noticed a nitpick: the indentation for the new method is 3 spaces.  Can
you please change the indentation to 2 spaces, which is the standard?
                
> Create a new HdfsConfiguration before each TestDFSClientRetries testcases
> -------------------------------------------------------------------------
>
>                 Key: HDFS-4787
>                 URL: https://issues.apache.org/jira/browse/HDFS-4787
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Tian Hong Wang
>            Assignee: Tian Hong Wang
>              Labels: patch
>             Fix For: 2.0.4-alpha
>
>         Attachments: HDFS-4787.java, HDFS-4787.patch, HDFS-4787-v1.patch
>
>
> It's better to create a new HdfsConfiguration before each testcases in TestDFSClientRetries
in case of any configuration parameter impact.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message