hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4765) Permission check of symlink deletion incorrectly throws UnresolvedLinkException
Date Sun, 12 May 2013 08:09:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13655492#comment-13655492
] 

Hadoop QA commented on HDFS-4765:
---------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12582823/hdfs-4765-2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new or modified
test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/4385//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/4385//console

This message is automatically generated.
                
> Permission check of symlink deletion incorrectly throws UnresolvedLinkException
> -------------------------------------------------------------------------------
>
>                 Key: HDFS-4765
>                 URL: https://issues.apache.org/jira/browse/HDFS-4765
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 3.0.0, 2.0.3-alpha
>            Reporter: Andrew Wang
>            Assignee: Andrew Wang
>         Attachments: hdfs-4765-1.patch, hdfs-4765-2.patch
>
>
> With permissions enabled, the permission check in {{FSNamesystem#delete}} will incorrectly
throw an UnresolvedLinkException if the path contains a symlink. This leads to FileContext
resolving the symlink and instead deleting the link target.
> The correct check is to see if the user has write permissions on the parent directory
of the symlink, e.g.
> {noformat}
> -> % ls -ld symtest
> drwxr-xr-x 2 root root 4096 Apr 26 14:12 symtest
> -> % ls -l symtest
> total 12
> lrwxrwxrwx 1 root root 6 Apr 26 14:12 link -> target
> -rw-r--r-- 1 root root 0 Apr 26 14:11 target
> -> % rm -f symtest/link
> rm: cannot remove `symtest/link': Permission denied
> -> % sudo chown andrew symtest
> -> % rm -f symtest/link       
> -> % 
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message