hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4300) TransferFsImage.downloadEditsToStorage should use a tmp file for destination
Date Mon, 13 May 2013 17:27:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656151#comment-13656151
] 

Aaron T. Myers commented on HDFS-4300:
--------------------------------------

+1, the latest patch looks good to me. I'm going to commit this momentarily.
                
> TransferFsImage.downloadEditsToStorage should use a tmp file for destination
> ----------------------------------------------------------------------------
>
>                 Key: HDFS-4300
>                 URL: https://issues.apache.org/jira/browse/HDFS-4300
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 2.0.2-alpha
>            Reporter: Todd Lipcon
>            Assignee: Andrew Wang
>            Priority: Critical
>         Attachments: hdfs-4300-1.patch, hdfs-4300-2.patch, hdfs-4300-3.patch, hdfs-4300-4.patch,
hdfs-4300-5.patch
>
>
> Currently, in TransferFsImage.downloadEditsToStorage, we download the edits file directly
to its finalized path. So, if the transfer fails in the middle, a half-written file is left
and cannot be distinguished from a correct file. So, future checkpoints by the 2NN will fail,
since the file is truncated in the middle -- but it won't ever download a good copy because
it thinks it already has the proper file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message