hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2261) AOP unit tests are not getting compiled or run
Date Tue, 07 May 2013 18:53:17 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13651177#comment-13651177
] 

Tsz Wo (Nicholas), SZE commented on HDFS-2261:
----------------------------------------------

For other un-mavenized artifacts such as forrest doc, we fix them instead of removing them.
 Why we must remove the fault injection tests?

> ... there is no way to compile/run them. I see that we were using ant the last time these
were checked, and there was a way to run them.

I don't agree.  It is just that our maven is not yet configured to support them.  I beg it
is easy to add a maven ant task to run them.

> ... Otherwise, we are essentially shipping releases with dead code and unused dependencies.

For the AspectJ dependency, I am fine to remove it for the moment.  Ideally, the main code
and the other test codes should not depend on AspectJ, only the fault injection tests should.
                
> AOP unit tests are not getting compiled or run 
> -----------------------------------------------
>
>                 Key: HDFS-2261
>                 URL: https://issues.apache.org/jira/browse/HDFS-2261
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0-alpha, 2.0.4-alpha
>         Environment: https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/834/console
> -compile-fault-inject ant target 
>            Reporter: Giridharan Kesavan
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: hdfs-2261.patch
>
>
> The tests in src/test/aop are not getting compiled or run.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message