Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B5AABF2BC for ; Tue, 30 Apr 2013 17:44:16 +0000 (UTC) Received: (qmail 19466 invoked by uid 500); 30 Apr 2013 17:44:16 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 19350 invoked by uid 500); 30 Apr 2013 17:44:16 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 19341 invoked by uid 99); 30 Apr 2013 17:44:16 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2013 17:44:16 +0000 Date: Tue, 30 Apr 2013 17:44:16 +0000 (UTC) From: "Aaron T. Myers (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4777) File creation with overwrite flag set to true results in logSync holding namesystem lock MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645767#comment-13645767 ] Aaron T. Myers commented on HDFS-4777: -------------------------------------- bq. My preference is to not logSync at all with FSNamesystem lock held. No disagreement there - just pointing out that it might be a little difficult to do in the case of entering safemode, and pointing out that it seems there's actually relatively few places that need to be addressed in order to get those tests passing. > File creation with overwrite flag set to true results in logSync holding namesystem lock > ---------------------------------------------------------------------------------------- > > Key: HDFS-4777 > URL: https://issues.apache.org/jira/browse/HDFS-4777 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 0.23.0, 2.0.0-alpha > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Priority: Blocker > Attachments: HDFS-4777.patch > > > FSNamesystem#startFileInternal calls delete. Delete method releases the write lock, making parts of startFileInternal code unintentionally executed without write lock being held. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira