Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 44BD1109E4 for ; Tue, 30 Apr 2013 13:16:18 +0000 (UTC) Received: (qmail 55108 invoked by uid 500); 30 Apr 2013 13:16:17 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 54868 invoked by uid 500); 30 Apr 2013 13:16:17 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 54850 invoked by uid 99); 30 Apr 2013 13:16:17 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Apr 2013 13:16:17 +0000 Date: Tue, 30 Apr 2013 13:16:17 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4773) Fix bugs in quota usage updating/computation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645561#comment-13645561 ] Hudson commented on HDFS-4773: ------------------------------ Integrated in Hadoop-Hdfs-Snapshots-Branch-build #173 (See [https://builds.apache.org/job/Hadoop-Hdfs-Snapshots-Branch-build/173/]) HDFS-4773. Fix bugs in quota usage computation and OfflineImageViewer. Contributed by Jing Zhao (Revision 1477367) Result = FAILURE szetszwo : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1477367 Files : * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/CHANGES.HDFS-2802.txt * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeFile.java * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/INodeReference.java * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/AbstractINodeDiffList.java * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/FileWithSnapshot.java * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/INodeDirectoryWithSnapshot.java * /hadoop/common/branches/HDFS-2802/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/ImageLoaderCurrent.java > Fix bugs in quota usage updating/computation > -------------------------------------------- > > Key: HDFS-4773 > URL: https://issues.apache.org/jira/browse/HDFS-4773 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: datanode, namenode > Reporter: Jing Zhao > Assignee: Jing Zhao > Priority: Minor > Fix For: Snapshot (HDFS-2802) > > Attachments: HDFS-4773.001.patch, HDFS-4773.002.patch, HDFS-4773.003.patch > > > 1. FileWithSnapshot#updateQuotaAndCollectBlocks did not consider the scenario that all the snapshots has been deleted from a snapshot copy of deleted file. This may lead to a divide-by-0 error. > 2. When computing the quota usage for a WithName node and its subtree, if the snapshot associated with the WithName node at the time of rename operation has been deleted, we should compute the quota based on the posterior snapshot. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira