Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 11 Apr 2013 13:07:21 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: <JIRA.12641705.1365536850702.149212.1365685641411@arcas>
In-Reply-To: <JIRA.12641705.1365536850702@arcas>
References: <JIRA.12641705.1365536850702@arcas>
Subject: [jira] [Commented] (HDFS-4679) Namenode operation checks should be
 done in a consistent manner
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-4679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628901#comment-13628901 ] 

Hudson commented on HDFS-4679:
------------------------------

Integrated in Hadoop-Hdfs-trunk #1369 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1369/])
    HDFS-4679. Namenode operation checks should be done in a consistent manner. Contributed by Suresh Srinivas. (Revision 1466721)

     Result = FAILURE
suresh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1466721
Files : 
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestSafeMode.java

                
> Namenode operation checks should be done in a consistent manner
> ---------------------------------------------------------------
>
>                 Key: HDFS-4679
>                 URL: https://issues.apache.org/jira/browse/HDFS-4679
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: namenode
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 2.0.5-beta
>
>         Attachments: HDFS-4679.patch, HDFS-4679.patch
>
>
> Different operations performs checks in different order. I propose consistently checking the following in namenode operations:
> # Print debug log related to the operation
> # validate the input parameters, file names
> # Grab read or write lock
> #* check if system is ready for read or write operation
> #* check if system is in safemode (for write operations)
> #* check permissions to see if the user is owner, has access or is super user privileges
> # Release the lock

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira