Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 329C8F640 for ; Sat, 13 Apr 2013 10:50:20 +0000 (UTC) Received: (qmail 75771 invoked by uid 500); 13 Apr 2013 10:50:19 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 75621 invoked by uid 500); 13 Apr 2013 10:50:19 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 75479 invoked by uid 99); 13 Apr 2013 10:50:18 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 13 Apr 2013 10:50:18 +0000 Date: Sat, 13 Apr 2013 10:50:18 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-4639) startFileInternal() should not increment generation stamp MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631007#comment-13631007 ] Hudson commented on HDFS-4639: ------------------------------ Integrated in Hadoop-Yarn-trunk #182 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/182/]) HDFS-4639. startFileInternal() should not increment generation stamp. Contributed by Plamen Jeliazkov. (Revision 1467534) Result = SUCCESS shv : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1467534 Files : * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSUpgrade.java * /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestCheckpoint.java > startFileInternal() should not increment generation stamp > --------------------------------------------------------- > > Key: HDFS-4639 > URL: https://issues.apache.org/jira/browse/HDFS-4639 > Project: Hadoop HDFS > Issue Type: Bug > Components: namenode > Affects Versions: 2.0.3-alpha > Reporter: Konstantin Shvachko > Assignee: Plamen Jeliazkov > Fix For: 2.0.5-beta > > Attachments: HDFS-4639.patch, HDFS-4639.patch, HDFS-4639.patch, HDFS-4639.trunk.patch > > > startFileInternal() increments genStamp and passes it to FSDirectory.addFile() as a parameter, while the addFile() simply ignores the generationStamp parameter. > We should remove the call of nextGenerationStamp() in startFileInternal() and eliminate the redundant parameter in FSDirectory.addFile(). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira