Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 045BAF2FD for ; Mon, 8 Apr 2013 21:28:23 +0000 (UTC) Received: (qmail 61410 invoked by uid 500); 8 Apr 2013 21:28:22 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 61373 invoked by uid 500); 8 Apr 2013 21:28:22 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 61364 invoked by uid 99); 8 Apr 2013 21:28:22 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Apr 2013 21:28:22 +0000 Date: Mon, 8 Apr 2013 21:28:22 +0000 (UTC) From: "Daryn Sharp (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HDFS-3447) StandbyException should not be logged at ERROR level on server MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-3447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625846#comment-13625846 ] Daryn Sharp commented on HDFS-3447: ----------------------------------- I know it's noisy at times, but it's helped me debug so many problems... Prior to HADOOP-7853, it's not that it used to log as DEBUG, it didn't log at all. I generally agree the caller should be expected to log the exception, but it won't be easy to track down every misbehaving caller (in the sense of not logging when it should). Plus callers rarely if ever prepend the UGI to the message when they log. Kihwal and I took at look at a few options. If it's moved to DEBUG, enabling that in UGI is going to spew a lot of undesired messages. If it's moved to INFO, with the default for UGI to be WARN, then other valuable logging will be lost. Adding another variant of doAs is undesirable because it's effectively the same as removing the logging entirely, plus someone like me would want every caller to pass the logging object. So what we came up with is would it make sense to have a second logger object in UGI, ex. a "detailed" logger, that would be used by doAs? > StandbyException should not be logged at ERROR level on server > -------------------------------------------------------------- > > Key: HDFS-3447 > URL: https://issues.apache.org/jira/browse/HDFS-3447 > Project: Hadoop HDFS > Issue Type: Improvement > Components: ha > Affects Versions: 2.0.0-alpha > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Labels: newbie > > Currently, the standby NN will log StandbyExceptions at ERROR level any time a client tries to connect to it. So, if the second NN in an HA pair is active, the first NN will spew a lot of these errors in the log, as each client gets redirected to the proper NN. Instead, this should be at INFO level, and should probably be logged in a less "scary" manner (eg "Received READ request from client 1.2.3.4, but in Standby state. Redirecting client to other NameNode.") -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira