hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4773) Fix bugs in quota usage updating/computation
Date Mon, 29 Apr 2013 17:00:19 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13644652#comment-13644652
] 

Tsz Wo (Nicholas), SZE commented on HDFS-4773:
----------------------------------------------

- getDiffById(final int snapshotId) and getDiff(Snapshot snapshot) are very similar.  Could
you change getDiff to call getDiffById?

- remove the commented code in FileWithSnapshot.

- Could you also fix TestOfflineImageViewer?
                
> Fix bugs in quota usage updating/computation
> --------------------------------------------
>
>                 Key: HDFS-4773
>                 URL: https://issues.apache.org/jira/browse/HDFS-4773
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: datanode, namenode
>            Reporter: Jing Zhao
>            Assignee: Jing Zhao
>            Priority: Minor
>         Attachments: HDFS-4773.001.patch
>
>
> 1. FileWithSnapshot#updateQuotaAndCollectBlocks did not consider the scenario that all
the snapshots has been deleted from a snapshot copy of deleted file. This may lead to a divide-by-0
error.
> 2. When computing the quota usage for a WithName node and its subtree, if the snapshot
associated with the WithName node at the time of rename operation has been deleted, we should
compute the quota based on the posterior snapshot.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message