hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Nauroth (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4693) Some test cases in TestCheckpoint do not clean up after themselves
Date Sun, 14 Apr 2013 16:20:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13631342#comment-13631342
] 

Chris Nauroth commented on HDFS-4693:
-------------------------------------

Thanks, Arpit.  It looks like there is still one more indent by 4 instead of 2 in {{testSecondaryNamenodeError2}}.

I am +1 for the patch though after that very minor nit is corrected.  Thanks for the patch!

{code}
@@ -426,6 +436,9 @@ public void testSecondaryNamenodeError2() throws IOException {
           replication, seed);
       checkFile(fileSys, file1, replication);
     } finally {
+      if (secondary != null) {
+          secondary.shutdown();
+      }
{code}

                
> Some test cases in TestCheckpoint do not clean up after themselves
> ------------------------------------------------------------------
>
>                 Key: HDFS-4693
>                 URL: https://issues.apache.org/jira/browse/HDFS-4693
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Arpit Agarwal
>            Assignee: Arpit Agarwal
>             Fix For: 3.0.0
>
>         Attachments: HDFS-4693.1.patch, HDFS-4693.2.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message