hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4639) startFileInternal() should not increment generation stamp
Date Sat, 13 Apr 2013 01:39:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630858#comment-13630858
] 

Konstantin Shvachko commented on HDFS-4639:
-------------------------------------------

+1. Looks good.
                
> startFileInternal() should not increment generation stamp
> ---------------------------------------------------------
>
>                 Key: HDFS-4639
>                 URL: https://issues.apache.org/jira/browse/HDFS-4639
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.0.3-alpha
>            Reporter: Konstantin Shvachko
>            Assignee: Plamen Jeliazkov
>         Attachments: HDFS-4639.patch, HDFS-4639.patch, HDFS-4639.patch, HDFS-4639.trunk.patch
>
>
> startFileInternal() increments genStamp and passes it to FSDirectory.addFile() as a parameter,
while the addFile() simply ignores the generationStamp parameter.
> We should remove the call of nextGenerationStamp() in startFileInternal() and eliminate
the redundant parameter in FSDirectory.addFile().

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message