hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-4434) Provide a mapping from INodeId to INode
Date Thu, 11 Apr 2013 17:51:16 GMT

     [ https://issues.apache.org/jira/browse/HDFS-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Suresh Srinivas updated HDFS-4434:
----------------------------------

    Attachment: HDFS-4434.patch

I have addressed all the comments with following exceptions:
bq. this method is merely normalizing the path by checking the prefix - i prefer the name
normalizePath
It does indeed resovle path based on INodeID. So retaining the same name for the method. Lets
me know if you are okay.

bq.  can improve the overhead of spliting the path if you check for the prefix in getPathComponents
OR do the split/concat in resolvePath. I see that you are minimizing what is done under the
lock.
I made some modifications where if the path is not reserved, splitting to components and resolving
pth is noop.

bq. ls of /.reserved (but not ls of /.reserved/inodes) - again this is best done in another
jira.
Not sure what this comment means.

bq. create a jira to not allow .reserved anywhere in the namespace
I am not sure we should restrict this name any where in the namespace. Could you please create
a jira and present a case for it?

bq. FSDirectory#addToInodeMap FSDirectory#removeFromInodeMap - suggestion - add suffix "Unprotected"?
(over time we should we change "internal" to unprotected)
Removed the method as it was doing very little

bq. Your new tests do not use the setup/teardown that the other tests do - add a comment or
move the new tests to a new file TestFsDirectory2.
Moved it to TestINodeFile


With this patch, I still expect TestCheckPoint to fail. Still debugging why the test runs
out of memory.

                
> Provide a mapping from INodeId to INode
> ---------------------------------------
>
>                 Key: HDFS-4434
>                 URL: https://issues.apache.org/jira/browse/HDFS-4434
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
HDFS-4434.patch, HDFS-4434.patch
>
>
> This JIRA is to provide a way to access the INode via its id. The proposed solution is
to have an in-memory mapping from INodeId to INode. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message