hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-4434) Provide a mapping from INodeId to INode
Date Tue, 09 Apr 2013 19:00:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-4434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13626950#comment-13626950
] 

Sanjay Radia commented on HDFS-4434:
------------------------------------

 Some early comments on my first skim of the code. More feedback future comment.
 * ResolvePath
 ** this method is merely normalizing the path by checking the prefix - i prefer the name
normalizePath
 ** Typo- javadoc of FSDirectory#resolvePath   -  @return if the *patch* indicates an inode,
 ** can improve the overhead of spliting the path if you check for the prefix in getPathComponents
OR do the split/concat in resolvePath.  I see that you are minimizing what is done under the
lock.
  Note down the road we should do the split in the begining and pass the components down to
the rest of code - this is a failry invasive change and should be done later in another jira.
 * symlink - note /.reserved does not make sense for target - hence you need to check for
it.
 * Related work for another Jira - .reserved should not be allowed anywhere. We may want to
allow chrooted file systems (note viewfs already has an internal client side fs to support
chrooted fs). We can discuss this further in the jira - disallowing at root is good enough
for this jira.
 * ls of /.reserved  (but not ls of /.reserved/inodes) - again this is best done in another
jira.
                
> Provide a mapping from INodeId to INode
> ---------------------------------------
>
>                 Key: HDFS-4434
>                 URL: https://issues.apache.org/jira/browse/HDFS-4434
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: namenode
>    Affects Versions: 3.0.0
>            Reporter: Brandon Li
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch, HDFS-4434.patch,
HDFS-4434.patch
>
>
> This JIRA is to provide a way to access the INode via its id. The proposed solution is
to have an in-memory mapping from INodeId to INode. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message